This repository was archived by the owner on Mar 4, 2020. It is now read-only.
feat(Dialog): add default aria-labelledby if not provided#1298
Merged
silviuaavram merged 9 commits intomasterfrom May 10, 2019
Merged
feat(Dialog): add default aria-labelledby if not provided#1298silviuaavram merged 9 commits intomasterfrom
silviuaavram merged 9 commits intomasterfrom
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1298 +/- ##
==========================================
+ Coverage 72.18% 72.55% +0.37%
==========================================
Files 754 754
Lines 5622 5647 +25
Branches 1671 1653 -18
==========================================
+ Hits 4058 4097 +39
+ Misses 1557 1544 -13
+ Partials 7 6 -1
Continue to review full report at Codecov.
|
sophieH29
reviewed
May 7, 2019
sophieH29
reviewed
May 7, 2019
jurokapsiar
reviewed
May 7, 2019
sophieH29
reviewed
May 7, 2019
packages/react/src/lib/accessibility/Behaviors/Dialog/dialogBehavior.ts
Outdated
Show resolved
Hide resolved
49c1c76 to
adc7244
Compare
sophieH29
approved these changes
May 9, 2019
jurokapsiar
reviewed
May 9, 2019
…com/stardust-ui/react into feat/dialog-default-aria-labelledby
jurokapsiar
approved these changes
May 10, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #812.
If Dialog has
aria-label, do nothing.If Dialog has
aria-labelledbby, do nothing.If Dialog does not have
aria-labeloraria-labelledby, getidfromheaderprop and use it asaria-labelledbyin Dialog.If Dialog does not have
aria-labeloraria-labelledby, andheaderis string or simply has noid, generateidand add it as default prop to header and asaria-labelledbyto Dialog.