This repository was archived by the owner on Mar 4, 2020. It is now read-only.
feat(Accordion): add a11y behavior for kb navigation and screen reader support#1322
Merged
silviuaavram merged 46 commits intomasterfrom May 22, 2019
Merged
feat(Accordion): add a11y behavior for kb navigation and screen reader support#1322silviuaavram merged 46 commits intomasterfrom
silviuaavram merged 46 commits intomasterfrom
Conversation
silviuaavram
requested review from
dvdzkwsk,
kuzhelov,
layershifter,
levithomason,
miroslavstastny and
mnajdova
as code owners
sophieH29
reviewed
May 14, 2019
mnajdova
reviewed
May 14, 2019
sophieH29
reviewed
May 14, 2019
mnajdova
reviewed
May 14, 2019
mnajdova
reviewed
May 14, 2019
mnajdova
reviewed
May 14, 2019
sophieH29
reviewed
May 14, 2019
sophieH29
reviewed
May 14, 2019
packages/react/src/lib/accessibility/Behaviors/Accordion/accordionTitleBehavior.ts
Outdated
Show resolved
Hide resolved
sophieH29
reviewed
May 14, 2019
mnajdova
reviewed
May 15, 2019
mnajdova
reviewed
May 17, 2019
mnajdova
reviewed
May 17, 2019
mnajdova
reviewed
May 17, 2019
mnajdova
reviewed
May 17, 2019
| <Box | ||
| onFocus={this.handleFocus} | ||
| onClick={this.handleClick} | ||
| className={AccordionTitle.slotClassNames.button} |
Contributor
There was a problem hiding this comment.
This is not button anymore, let's change the name of the slotClassNames
Contributor
There was a problem hiding this comment.
One more question, do we really need the box around the Layout? The Layout itself is a div, can't we just use the Layout component here?
mnajdova
reviewed
May 17, 2019
mnajdova
reviewed
May 17, 2019
mnajdova
reviewed
May 17, 2019
mnajdova
reviewed
May 17, 2019
mnajdova
reviewed
May 17, 2019
Contributor
|
We can use |
sophieH29
reviewed
May 17, 2019
mnajdova
reviewed
May 17, 2019
…-ui/react into feat-accordion-behavior
mnajdova
approved these changes
May 22, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Work that aims to implement the Accordion design pattern from aria. https://www.w3.org/TR/2017/NOTE-wai-aria-practices-1.1-20171214/#accordion and example https://www.w3.org/TR/2017/NOTE-wai-aria-practices-1.1-20171214/examples/accordion/accordion.html
Changes:
Boxwith abuttonrole between root andLayout.dl,dhandddfor accordion, title and content.expandedAccordion type. With it truthy, it will always keep a panel open.ContainerFocusHandlerto support this.-added unit tests for Accordion, Title, Content and behaviors.
Work in progress: