This repository was archived by the owner on Mar 4, 2020. It is now read-only.
fix(IconBehavior): changing icon behavior as for some cases icon could be visible#1327
Merged
fix(IconBehavior): changing icon behavior as for some cases icon could be visible#1327
Conversation
…con inside the table
kolaps33
requested review from
dvdzkwsk,
kuzhelov,
layershifter,
levithomason,
miroslavstastny and
mnajdova
as code owners
sophieH29
approved these changes
May 13, 2019
Contributor
|
The changes looks good, but let's fist fix the failing test before final approval. |
Codecov Report
@@ Coverage Diff @@
## master #1327 +/- ##
==========================================
- Coverage 73% 72.92% -0.09%
==========================================
Files 775 775
Lines 5823 5824 +1
Branches 1720 1698 -22
==========================================
- Hits 4251 4247 -4
- Misses 1566 1571 +5
Partials 6 6
Continue to review full report at Codecov.
|
kolaps33
changed the title
kolaps33
changed the title
mnajdova
approved these changes
May 22, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
During table examples implementation, we figure out icon could be visible inside the table cell. In order not narrate empty cell for user.
And if icon should behave correctly it should have role image.