This repository was archived by the owner on Mar 4, 2020. It is now read-only.
feat(Icon): Adding lightning icon for Teams theme#1385
Merged
Conversation
notandrew
requested review from
dvdzkwsk,
kuzhelov,
layershifter,
levithomason,
miroslavstastny and
mnajdova
as code owners
Codecov Report
@@ Coverage Diff @@
## master #1385 +/- ##
==========================================
+ Coverage 73.47% 73.47% +<.01%
==========================================
Files 777 778 +1
Lines 5858 5859 +1
Branches 1706 1726 +20
==========================================
+ Hits 4304 4305 +1
Misses 1548 1548
Partials 6 6
Continue to review full report at Codecov.
|
Contributor
|
looks good to me :) just one thing to ensure before merge - was this icon verified by designers? @codepretty |
kuzhelov
approved these changes
May 24, 2019
codepretty
reviewed
May 24, 2019
codepretty
approved these changes
May 24, 2019
codepretty
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adding lightning icon: