This repository was archived by the owner on Mar 4, 2020. It is now read-only.
chore(behavior): rename toolbarBehavior to menuAsToolbarBehavior#1393
Merged
miroslavstastny merged 7 commits intomasterfrom Jun 3, 2019
Merged
chore(behavior): rename toolbarBehavior to menuAsToolbarBehavior#1393miroslavstastny merged 7 commits intomasterfrom
miroslavstastny merged 7 commits intomasterfrom
Conversation
miroslavstastny
requested review from
dvdzkwsk,
kuzhelov,
layershifter,
levithomason and
mnajdova
as code owners
Codecov Report
@@ Coverage Diff @@
## master #1393 +/- ##
=======================================
Coverage 73.27% 73.27%
=======================================
Files 802 802
Lines 6025 6025
Branches 1775 1756 -19
=======================================
Hits 4415 4415
Misses 1604 1604
Partials 6 6
Continue to review full report at Codecov.
|
miroslavstastny
commented
May 26, 2019
| key: 'show-code', | ||
| content: <ComponentButton iconName="code" label="Try it" />, | ||
| onClick: onShowCode, | ||
| accessibility: toolbarButtonBehavior, |
Contributor
|
@miroslavstastny shouldn't it be |
layershifter
approved these changes
May 27, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
BREAKING CHANGE
toolbarBehaviortomenuAsToolbarBehaviortoolbarButtonBehaviortomenuItemAsToolbarButtonBehaviorDetails
We plan to add
toolbarBehaviorto be used byToolbarcomponent, therefore we need to rename existingtoolbarBehavior.Current
toolbarBehaviorwhich usestoolbarButtonBehaviorexpect children items to havewrapperandrootslots - this works forMenucomponent (which renders asul > li > a) but is not suitable forToolbarcomponent (which is expected to render asdiv > button).Discussed offline with @jurokapsiar