This repository was archived by the owner on Mar 4, 2020. It is now read-only.
fix(Accordion.Title): make contentRef prop optional#1418
Merged
Conversation
bmdalex
requested review from
dvdzkwsk,
kuzhelov,
layershifter,
levithomason,
miroslavstastny and
mnajdova
as code owners
kuzhelov
changed the title
kuzhelov
approved these changes
May 29, 2019
Codecov Report
@@ Coverage Diff @@
## master #1418 +/- ##
=======================================
Coverage 73.59% 73.59%
=======================================
Files 787 787
Lines 5889 5889
Branches 1717 1717
=======================================
Hits 4334 4334
Misses 1549 1549
Partials 6 6
Continue to review full report at Codecov.
|
silviuaavram
suggested changes
May 29, 2019
bmdalex
force-pushed
the
fix/accordion-title-content-ref
branch
from
1c99c6b to
675cea9
Compare
bmdalex
commented
May 29, 2019
packages/react/test/specs/components/Accordion/AccordionTitle-test.tsx
Outdated
Show resolved
Hide resolved
silviuaavram
approved these changes
May 29, 2019
bmdalex
force-pushed
the
fix/accordion-title-content-ref
branch
from
675cea9 to
2fd9c30
Compare
layershifter
approved these changes
May 29, 2019
bmdalex
force-pushed
the
fix/accordion-title-content-ref
branch
from
2fd9c30 to
6d43133
Compare
bmdalex
force-pushed
the
fix/accordion-title-content-ref
branch
from
6d43133 to
d759fbc
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix(Accordion.Title): make contentRef prop optional
Fixes #1417