Skip to content
This repository was archived by the owner on Mar 4, 2020. It is now read-only.

fix(ListItem): end media in Teams theme breaks ButtonGroup styles#1448

Merged
mnajdova merged 3 commits intomasterfrom
fix/list-item-end-media
Jun 4, 2019
Merged

fix(ListItem): end media in Teams theme breaks ButtonGroup styles#1448
mnajdova merged 3 commits intomasterfrom
fix/list-item-end-media

Conversation

@mnajdova
Copy link
Contributor

@mnajdova mnajdova commented Jun 4, 2019

Fix #1287

ButtonGroup style were broken when inside endMedia of ListItem.

Before:
image

After:
image

@codecov
Copy link

codecov bot commented Jun 4, 2019

Codecov Report

Merging #1448 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1448   +/-   ##
=======================================
  Coverage   73.14%   73.14%           
=======================================
  Files         805      805           
  Lines        6073     6073           
  Branches     1775     1775           
=======================================
  Hits         4442     4442           
  Misses       1625     1625           
  Partials        6        6
Impacted Files Coverage Δ
...src/themes/teams/components/List/listItemStyles.ts 23.8% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b5ad236...1ee6ea8. Read the comment docs.

@mnajdova mnajdova merged commit 33effdd into master Jun 4, 2019
@delete-merged-branch delete-merged-branch bot deleted the fix/list-item-end-media branch June 4, 2019 14:23
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

ButtonGroup style breaking when inside endMedia of ListItem

3 participants