Skip to content
This repository was archived by the owner on Mar 4, 2020. It is now read-only.

feat(Tree): expand all siblings on asterisk key#1457

Merged
silviuaavram merged 14 commits intomasterfrom
feat/expand-subtrees-asterisk-key
Jun 10, 2019
Merged

feat(Tree): expand all siblings on asterisk key#1457
silviuaavram merged 14 commits intomasterfrom
feat/expand-subtrees-asterisk-key

Conversation

@silviuaavram
Copy link
Collaborator

Follows the pattern at https://www.w3.org/TR/wai-aria-practices-1.1/examples/treeview/treeview-1/treeview-1a.html in the keyboard support 'asterisk' section.

On asterisk key, the tree and all its siblings are expanded.

@silviuaavram silviuaavram added accessibility All the Accessibility tasks and bugs should be tagged with this. 🚀 ready for review labels Jun 5, 2019
@codecov
Copy link

codecov bot commented Jun 5, 2019

Codecov Report

Merging #1457 into master will increase coverage by 0.33%.
The diff coverage is 88.23%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1457      +/-   ##
==========================================
+ Coverage   73.14%   73.47%   +0.33%     
==========================================
  Files         805      806       +1     
  Lines        6073     6089      +16     
  Branches     1794     1780      -14     
==========================================
+ Hits         4442     4474      +32     
+ Misses       1625     1609      -16     
  Partials        6        6
Impacted Files Coverage Δ
...ages/react/test/specs/behaviors/testDefinitions.ts 98.3% <ø> (ø) ⬆️
packages/react/src/components/Tree/TreeItem.tsx 80% <ø> (+73.33%) ⬆️
...c/lib/accessibility/Behaviors/Tree/treeBehavior.ts 100% <100%> (ø) ⬆️
...ib/accessibility/Behaviors/Tree/subtreeBehavior.ts 100% <100%> (ø)
packages/react/src/components/Tree/Tree.tsx 71.42% <84.61%> (+16.25%) ⬆️
packages/react/src/components/Tree/TreeTitle.tsx 50% <0%> (+40%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bc45706...bd17618. Read the comment docs.

@silviuaavram silviuaavram merged commit 6487506 into master Jun 10, 2019
@delete-merged-branch delete-merged-branch bot deleted the feat/expand-subtrees-asterisk-key branch June 10, 2019 14:09
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

accessibility All the Accessibility tasks and bugs should be tagged with this. 🚀 ready for review

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants