This repository was archived by the owner on Mar 4, 2020. It is now read-only.
fix(felaPluginFallbackValue): broken because of order of plugins#1461
Merged
fix(felaPluginFallbackValue): broken because of order of plugins#1461
Conversation
mnajdova
requested review from
dvdzkwsk,
kuzhelov,
layershifter,
levithomason and
miroslavstastny
as code owners
mnajdova
commented
Jun 6, 2019
| const ProviderExampleShorthand = () => ( | ||
| <Segment | ||
| content="Segment with blue border" | ||
| styles={{ border: ['1px solid red', '1px solid blue'] as any }} |
Contributor
Author
There was a problem hiding this comment.
We should update the typings for this, currently an array is not a valid border value...
Member
There was a problem hiding this comment.
If we want to use visual tests for this I would propose to add one red segment with ['1px solid red', '1px solid invalid'] to verify that both values from the array are written to the styles.
Codecov Report
@@ Coverage Diff @@
## master #1461 +/- ##
=======================================
Coverage 73.14% 73.14%
=======================================
Files 805 805
Lines 6073 6073
Branches 1775 1794 +19
=======================================
Hits 4442 4442
Misses 1625 1625
Partials 6 6
Continue to review full report at Codecov.
|
miroslavstastny
approved these changes
Jun 6, 2019
kuzhelov
approved these changes
Jun 6, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix #1460 After introducing the
felaExpandCssShorthandsPluginthefelaPluginFallbackValuewas broken, because of the wrong order of the plugins. ThefelaExpandCssShorthandsPluginshould run after thefelaPluginFallbackValue. As part of the PR there is a screenshot test added that will ensure the fallback value plugin is working as expected.