This repository was archived by the owner on Mar 4, 2020. It is now read-only.
feat(Toolbar): Add toolbarBehavior and toolbarItemBehavior#1468
Merged
feat(Toolbar): Add toolbarBehavior and toolbarItemBehavior#1468
Conversation
added 2 commits
June 6, 2019 18:09
sophieH29
added
⚙️ enhancement
sophieH29
requested review from
dvdzkwsk,
kuzhelov,
layershifter,
levithomason,
miroslavstastny and
mnajdova
as code owners
added 2 commits
June 7, 2019 14:16
silviuaavram
reviewed
Jun 7, 2019
silviuaavram
reviewed
Jun 7, 2019
packages/react/src/lib/accessibility/Behaviors/Button/toggleButtonBehavior.ts
Outdated
Show resolved
Hide resolved
silviuaavram
approved these changes
Jun 7, 2019
miroslavstastny
approved these changes
Jun 10, 2019
jurokapsiar
approved these changes
Jun 10, 2019
# Conflicts: # packages/react/src/lib/accessibility/Behaviors/Button/buttonBehavior.ts # packages/react/src/lib/accessibility/Behaviors/Button/toggleButtonBehavior.ts
jurokapsiar
reviewed
Jun 15, 2019
Codecov Report
@@ Coverage Diff @@
## master #1468 +/- ##
=========================================
- Coverage 73.23% 73.2% -0.03%
=========================================
Files 822 823 +1
Lines 6198 6221 +23
Branches 1802 1805 +3
=========================================
+ Hits 4539 4554 +15
- Misses 1654 1662 +8
Partials 5 5
Continue to review full report at Codecov.
|
# Conflicts: # packages/react/src/components/Toolbar/ToolbarItem.tsx
Collaborator
Generated by 🚫 dangerJS |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #1413
buttonBehaviortoggleButtonBehaviortoolbarItemBehavior