This repository was archived by the owner on Mar 4, 2020. It is now read-only.
fix(Popup): click/keypress handling logic for content#1482
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1482 +/- ##
=======================================
Coverage 73.59% 73.59%
=======================================
Files 807 807
Lines 6117 6117
Branches 1804 1785 -19
=======================================
Hits 4502 4502
Misses 1609 1609
Partials 6 6
Continue to review full report at Codecov.
|
layershifter
approved these changes
Jun 10, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1324
TODO
Problem
Click on popup content's button toggles popup content to close.
Cause
The cause of the problem is rather convoluted. The reason popup closes is because it 'sees' click on the content's button as outside click.
Why?
Popuphas the following logic to detect outside clicksWhile idea is straightforward, it turns out that currently we have problems caused by order of click events processing. When button inside of popup content is clicked,
Resolution
To address it, for now,
captureprop of popup's<EventListener />is used - this activatescapturesubscription mode for DOM events, which guarantees that corresponding event handler will be invoked before any other event's effects. (https://developer.mozilla.org/ru/docs/Web/API/EventTarget/addEventListener)Additional notes
These changes will be merged after #1463 , where e2e (browser) test is introduced for the issue's case.