This repository was archived by the owner on Mar 4, 2020. It is now read-only.
fix(styles): update definition of FontFace and rename FontFaceStyle#1487
Merged
layershifter merged 7 commits intomasterfrom Jun 18, 2019
Merged
fix(styles): update definition of FontFace and rename FontFaceStyle#1487layershifter merged 7 commits intomasterfrom
FontFace and rename FontFaceStyle#1487layershifter merged 7 commits intomasterfrom
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1487 +/- ##
=======================================
Coverage 73.25% 73.25%
=======================================
Files 825 825
Lines 6207 6207
Branches 1778 1778
=======================================
Hits 4547 4547
Misses 1655 1655
Partials 5 5
Continue to review full report at Codecov.
|
7be8477 to
c0ef9a6
Compare
layershifter
commented
Jun 18, 2019
miroslavstastny
approved these changes
Jun 18, 2019
bmdalex
approved these changes
Jun 18, 2019
FontFace and rename FontFaceStyle
layershifter
commented
Jun 18, 2019
| fontVariant?: string | ||
| fontWeight?: number | ||
| localAlias?: string | ||
| localAlias?: string | string[] |
Member
Author
There was a problem hiding this comment.
According to Fela definitions: localAlias?: string | Array<string>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1454.
BREAKING CHANGES
Our
FontFacedefinition haven't matched FelarenderFont():So when are passing
localAliasit looks that we are passing it tostylewhat it is completely weird:Migration
This PR contains:
FontFaceStyletoFontFacePropsstyletopropsonFontFacetypeconst fontFaces: FontFaces = [ { name: 'Segoe UI', paths: [], - style: { fontWeight: 400 }, + props: { fontWeight: 400 }, }, ]