Skip to content
This repository was archived by the owner on Mar 4, 2020. It is now read-only.

fix(RadioGroup): First item should be tabbable by default when none of the items selected#1515

Merged
sophieH29 merged 8 commits intomasterfrom
fix/radio-group-default-focused-element
Jun 24, 2019
Merged

fix(RadioGroup): First item should be tabbable by default when none of the items selected#1515
sophieH29 merged 8 commits intomasterfrom
fix/radio-group-default-focused-element

Conversation

@sophieH29
Copy link
Contributor

@sophieH29 sophieH29 commented Jun 18, 2019

Fixes #1351

@sophieH29 sophieH29 added 🚀 ready for review 🧰 fix Introduces fix for broken behavior. accessibility All the Accessibility tasks and bugs should be tagged with this. labels Jun 18, 2019
@sophieH29 sophieH29 self-assigned this Jun 18, 2019
@sophieH29 sophieH29 changed the title fix(RadioGroup): First item should be focusable by default when none of the items selected fix(RadioGroup): First item should be tabbable by default when none of the items selected Jun 18, 2019
@DustyTheBot
Copy link
Collaborator

DustyTheBot commented Jun 18, 2019

Fails
🚫 Invalid entry format in CHANGELOG.md: >+- Fix `RadioGroup` first item should be tabbable by default when none of the items selected @sophieH29 ([#1515](https://github.com//pull/1515)) <

Generated by 🚫 dangerJS

@codecov
Copy link

codecov bot commented Jun 18, 2019

Codecov Report

Merging #1515 into master will decrease coverage by 0.03%.
The diff coverage is 73.33%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1515      +/-   ##
==========================================
- Coverage   73.21%   73.17%   -0.04%     
==========================================
  Files         828      828              
  Lines        6212     6219       +7     
  Branches     1780     1784       +4     
==========================================
+ Hits         4548     4551       +3     
- Misses       1659     1663       +4     
  Partials        5        5
Impacted Files Coverage Δ
...sibility/Behaviors/Radio/radioGroupItemBehavior.ts 100% <ø> (ø) ⬆️
...react/src/components/RadioGroup/RadioGroupItem.tsx 85.71% <62.5%> (-14.29%) ⬇️
...ges/react/src/components/RadioGroup/RadioGroup.tsx 92% <85.71%> (-1.48%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 558a5f0...1eccd4b. Read the comment docs.

@jurokapsiar
Copy link
Contributor

The arrow navigation looks good.

Since now it is possible to focus unchecked item, we need to add support for Space bar as suggested by ARIA:

If the radio button with focus is not checked, changes the state to checked.
Otherwise, does nothing.
Note: The state where a radio is not checked only occurs on page load.

@sophieH29 sophieH29 merged commit 7f0c08b into master Jun 24, 2019
@sophieH29 sophieH29 deleted the fix/radio-group-default-focused-element branch June 24, 2019 14:54
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

accessibility All the Accessibility tasks and bugs should be tagged with this. 🧰 fix Introduces fix for broken behavior. 🚀 ready for review

Projects

None yet

Development

Successfully merging this pull request may close these issues.

RadioGroupItems not tab-accessible if NO default RadioGroupItem checked

3 participants