This repository was archived by the owner on Mar 4, 2020. It is now read-only.
fix(Dropdown, DropdownItem, ListItem): Updating theme files#1523
Merged
fix(Dropdown, DropdownItem, ListItem): Updating theme files#1523
Conversation
…x/dropdown-themeing
…x/dropdown-themeing
…x/dropdown-themeing
…x/dropdown-themeing
…x/dropdown-themeing
…x/dropdown-themeing
…x/dropdown-themeing
fixing problem with image right margin.
bcalvery
requested review from
dvdzkwsk,
kuzhelov,
layershifter,
levithomason,
miroslavstastny and
mnajdova
as code owners
bcalvery
commented
Jun 20, 2019
packages/react/src/themes/teams/components/Dropdown/dropdownItemStyles.ts
Outdated
Show resolved
Hide resolved
Codecov Report
@@ Coverage Diff @@
## master #1523 +/- ##
==========================================
- Coverage 71.66% 71.55% -0.12%
==========================================
Files 838 838
Lines 6850 6858 +8
Branches 1961 1947 -14
==========================================
- Hits 4909 4907 -2
- Misses 1935 1945 +10
Partials 6 6
Continue to review full report at Codecov.
|
bcalvery
changed the title
codepretty
reviewed
Jun 21, 2019
codepretty
reviewed
Jun 21, 2019
packages/react/src/themes/teams/components/Dropdown/dropdownItemStyles.ts
Outdated
Show resolved
Hide resolved
packages/react/src/themes/teams/components/Dropdown/dropdownItemStyles.ts
Outdated
Show resolved
Hide resolved
bcalvery
changed the title
levithomason
approved these changes
Jun 26, 2019
Member
levithomason
left a comment
levithomason
left a comment
There was a problem hiding this comment.
If the redline is correct here, let's merge 👍
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Redline match for Dropdown and DropdownItem.
before:
after:
The redlines call for a "selected indictor" (checkmark) next to any item that is currently selected in the dropdown, and that is not implemented here because this is supposed to just be a style update.
