This repository was archived by the owner on Mar 4, 2020. It is now read-only.
fix: refactored highlightedIndex on Arrow keydown#1570
Merged
silviuaavram merged 5 commits intomasterfrom Jul 3, 2019
Merged
Conversation
silviuaavram
added
🚀 ready for review
accessibility
silviuaavram
requested review from
dvdzkwsk,
kuzhelov,
layershifter,
levithomason,
miroslavstastny and
mnajdova
as code owners
Codecov Report
@@ Coverage Diff @@
## master #1570 +/- ##
==========================================
- Coverage 71.66% 71.63% -0.03%
==========================================
Files 848 848
Lines 6910 6910
Branches 1963 1981 +18
==========================================
- Hits 4952 4950 -2
- Misses 1952 1954 +2
Partials 6 6
Continue to review full report at Codecov.
|
jurokapsiar
approved these changes
Jul 3, 2019
delete-merged-branch
bot
deleted the
fix/dropdown-highlightedIndex-on-open
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Initiate
highlightedIndexon ArrowUp and ArrowDown open.Refactored how the index is calculated.
If user passes anything related to highlightedIndex, then we don't change its value on open, even on Arrow Up/Down. This includes controlled
highlightedIndex,defaultHighlightedIndexorhighlightFirstItemOnOpen.Fixes #1176
Avoided major refactoring in this area as I want to use hooks in the future rather than have this logic here anymore.