This repository was archived by the owner on Mar 4, 2020. It is now read-only.
feat(Tooltip): add svg beak in Teams theme#1580
Merged
Conversation
mnajdova
requested review from
dvdzkwsk,
kuzhelov,
layershifter,
levithomason and
miroslavstastny
as code owners
Codecov Report
@@ Coverage Diff @@
## master #1580 +/- ##
==========================================
- Coverage 71.68% 71.53% -0.16%
==========================================
Files 847 847
Lines 6915 6931 +16
Branches 1965 1997 +32
==========================================
+ Hits 4957 4958 +1
- Misses 1952 1967 +15
Partials 6 6
Continue to review full report at Codecov.
|
mnajdova
changed the title
added 2 commits
July 3, 2019 16:15
-fixed rtl issue
kuzhelov
reviewed
Jul 8, 2019
packages/react/src/themes/teams/components/Tooltip/tooltipContentStyles.ts
Outdated
Show resolved
Hide resolved
kuzhelov
reviewed
Jul 8, 2019
packages/react/src/themes/teams/components/Tooltip/tooltipContentStyles.ts
Outdated
Show resolved
Hide resolved
kuzhelov
approved these changes
Jul 8, 2019
layershifter
reviewed
Jul 8, 2019
packages/react/src/themes/teams/components/Tooltip/tooltipPointerSvgUrl.ts
Outdated
Show resolved
Hide resolved
layershifter
reviewed
Jul 8, 2019
added 3 commits
July 9, 2019 10:43
# Conflicts: # CHANGELOG.md
Codecov Report
@@ Coverage Diff @@
## master #1580 +/- ##
==========================================
- Coverage 71.68% 71.53% -0.16%
==========================================
Files 847 847
Lines 6915 6931 +16
Branches 1965 1977 +12
==========================================
+ Hits 4957 4958 +1
- Misses 1952 1967 +15
Partials 6 6
Continue to review full report at Codecov.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds svg pointing beak to the Tooltip component in Teams theme. No API changes were made.