Skip to content
This repository was archived by the owner on Mar 4, 2020. It is now read-only.

fix(docs): Code in Theming Examples does not have a corresponding output#1616

Merged
lucivpav merged 10 commits intomicrosoft:masterfrom
lucivpav:docs/theming-examples-nesting-themes-fix
Jul 15, 2019
Merged

fix(docs): Code in Theming Examples does not have a corresponding output#1616
lucivpav merged 10 commits intomicrosoft:masterfrom
lucivpav:docs/theming-examples-nesting-themes-fix

Conversation

@lucivpav
Copy link
Contributor

This resolves issue #1597. The code in docs did not correspond to the actual output. Futhermore the code was outdated, resulting in not doing what it was intended to do.

Before:
orig

After:
image

@vercel
Copy link

vercel bot commented Jul 11, 2019

This pull request is automatically deployed with Now.
To access deployments, click Details below or on the icon next to each push.

Latest deployment for this branch: https://stardust-react-git-fork-lucivpav-docs-theming-examples-c7c498.stardust-ui.now.sh

@DustyTheBot
Copy link
Collaborator

Warnings
⚠️ There are no updates provided to CHANGELOG. Ensure there are no publicly visible changes introduced by this PR.

Generated by 🚫 dangerJS

@codecov
Copy link

codecov bot commented Jul 11, 2019

Codecov Report

❗ No coverage uploaded for pull request base (master@f755bfc). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #1616   +/-   ##
=========================================
  Coverage          ?   71.53%           
=========================================
  Files             ?      848           
  Lines             ?     6932           
  Branches          ?     1977           
=========================================
  Hits              ?     4959           
  Misses            ?     1967           
  Partials          ?        6

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f755bfc...fe70611. Read the comment docs.

@codecov
Copy link

codecov bot commented Jul 11, 2019

Codecov Report

❗ No coverage uploaded for pull request base (master@424ba3c). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #1616   +/-   ##
=========================================
  Coverage          ?   71.28%           
=========================================
  Files             ?      846           
  Lines             ?     6938           
  Branches          ?     1982           
=========================================
  Hits              ?     4946           
  Misses            ?     1986           
  Partials          ?        6

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 424ba3c...dd2a53e. Read the comment docs.

@mnajdova mnajdova changed the title fix Code in Theming Examples does not have a corresponding output fix(docs): Code in Theming Examples does not have a corresponding output Jul 11, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants