This repository was archived by the owner on Mar 4, 2020. It is now read-only.
feat(Accessibility): Split action handlers with "OR" condition#1622
Merged
feat(Accessibility): Split action handlers with "OR" condition#1622
Conversation
sophieH29
requested review from
dvdzkwsk,
kuzhelov,
layershifter,
levithomason,
miroslavstastny and
mnajdova
as code owners
Codecov Report
@@ Coverage Diff @@
## master #1622 +/- ##
=========================================
+ Coverage 71.28% 71.49% +0.2%
=========================================
Files 846 846
Lines 6938 6945 +7
Branches 1982 1982
=========================================
+ Hits 4946 4965 +19
+ Misses 1986 1974 -12
Partials 6 6
Continue to review full report at Codecov.
|
| /** Checks if current tree item has a subtree and it is opened */ | ||
| const isSubtreeOpen = (props: TreeItemBehaviorProps): boolean => { | ||
| const { items, open } = props | ||
| return !!(items && items.length && open) |
Member
There was a problem hiding this comment.
Was it determined that checking open alone was not sufficient?
Contributor
Author
There was a problem hiding this comment.
yes, in TreeItem subtree is only rendered if open === true and items is not an empty array
levithomason
approved these changes
Jul 11, 2019
Member
levithomason
left a comment
levithomason
left a comment
There was a problem hiding this comment.
Just one comment, address as you see fit and merge 👍
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Based on this initial PR #1588, there was made a decision to split actions in separate PR. And re-think conditional handlers in further discussions.