This repository was archived by the owner on Mar 4, 2020. It is now read-only.
Merged
Conversation
…m/stardust-ui/react into fix/update-component-descriptions
mnajdova
reviewed
Jul 12, 2019
mnajdova
reviewed
Jul 12, 2019
mnajdova
reviewed
Jul 12, 2019
mnajdova
reviewed
Jul 12, 2019
mnajdova
reviewed
Jul 12, 2019
Codecov Report
@@ Coverage Diff @@
## master #1629 +/- ##
=======================================
Coverage 71.28% 71.28%
=======================================
Files 852 852
Lines 7045 7045
Branches 2029 2029
=======================================
Hits 5022 5022
Misses 2017 2017
Partials 6 6
Continue to review full report at Codecov.
|
mnajdova
reviewed
Jul 12, 2019
hughreeling
reviewed
Jul 15, 2019
hughreeling
reviewed
Jul 15, 2019
hughreeling
reviewed
Jul 15, 2019
jurokapsiar
reviewed
Jul 15, 2019
silviuaavram
approved these changes
Jul 16, 2019
kolaps33
approved these changes
Jul 16, 2019
sophieH29
approved these changes
Jul 16, 2019
…m/stardust-ui/react into fix/update-component-descriptions
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Goal
This PR aims to ensure that for each component there are the following pieces provided
Visual aspects of how this data is presented by docs are left outside of this PR, as its main focus is to refine, organise and make consistent the actual content (component description) that should be rendered.
Unify component names' formatting in descriptions
Previously there were no consistency, and both these approaches were used for Stardust components (based on previous component descriptions):
This PR unifies the approach for all components, by favouring the uppercased way for component references. This is done for the following reasons:
This is not the only example - similar semantic differences could be seen for the following components:
InputTollbarMenuDividerEmbedToolbarDividerReferences used