This repository was archived by the owner on Mar 4, 2020. It is now read-only.
docs(perf): improve rendering perf for examples#1654
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1654 +/- ##
=========================================
Coverage ? 71.28%
=========================================
Files ? 852
Lines ? 7045
Branches ? 2029
=========================================
Hits ? 5022
Misses ? 2017
Partials ? 6Continue to review full report at Codecov.
|
bmdalex
force-pushed
the
docs/improve-examples-loading-perf
branch
from
7c0c1e0 to
df5e73d
Compare
bmdalex
requested review from
dvdzkwsk,
kuzhelov,
layershifter,
levithomason,
miroslavstastny and
mnajdova
as code owners
bmdalex
force-pushed
the
docs/improve-examples-loading-perf
branch
from
df5e73d to
0fb3b3d
Compare
- addressed PR comments
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
docs(perf): improve rendering perf for examples
Description:
This PR is focused on improving docs usage experience.
Performance is gained by using placeholders for invisible components.
Each page is loading faster now 🚀
Inspired by @layershifter 's PR in SUIR 🙇
Before
https://imgur.com/a/t6iKNNW
After
https://imgur.com/a/cjN5oNM