This repository was archived by the owner on Mar 4, 2020. It is now read-only.
fix(Checkbox): refined styles to match redline and add dark and contrast theme#1656
Merged
fix(Checkbox): refined styles to match redline and add dark and contrast theme#1656
Conversation
bcalvery
requested review from
dvdzkwsk,
kuzhelov,
layershifter,
levithomason,
miroslavstastny and
mnajdova
as code owners
bcalvery
commented
Jul 16, 2019
packages/react/src/themes/teams/components/Checkbox/checkboxStyles.ts
Outdated
Show resolved
Hide resolved
Codecov Report
@@ Coverage Diff @@
## master #1656 +/- ##
==========================================
- Coverage 71.17% 71.02% -0.15%
==========================================
Files 858 859 +1
Lines 7111 7134 +23
Branches 2034 2049 +15
==========================================
+ Hits 5061 5067 +6
- Misses 2044 2061 +17
Partials 6 6
Continue to review full report at Codecov.
|
codepretty
reviewed
Jul 16, 2019
codepretty
reviewed
Jul 16, 2019
packages/react/src/themes/teams-dark/components/Checkbox/checkboxVariables.ts
Outdated
Show resolved
Hide resolved
codepretty
reviewed
Jul 16, 2019
packages/react/src/themes/teams/components/Checkbox/checkboxVariables.ts
Outdated
Show resolved
Hide resolved
codepretty
reviewed
Jul 16, 2019
packages/react/src/themes/teams/components/Checkbox/checkboxVariables.ts
Outdated
Show resolved
Hide resolved
codepretty
reviewed
Jul 16, 2019
packages/react/src/themes/teams/components/Checkbox/checkboxVariables.ts
Outdated
Show resolved
Hide resolved
codepretty
reviewed
Jul 16, 2019
packages/react/src/themes/teams/components/Checkbox/checkboxVariables.ts
Outdated
Show resolved
Hide resolved
codepretty
reviewed
Jul 16, 2019
packages/react/src/themes/teams-high-contrast/components/Checkbox/checkboxVariables.ts
Outdated
Show resolved
Hide resolved
mnajdova
reviewed
Jul 17, 2019
packages/react/src/themes/base/components/Checkbox/checkboxStyles.ts
Outdated
Show resolved
Hide resolved
alinais
approved these changes
Jul 19, 2019
alinais
reviewed
Jul 22, 2019
| checkedBackground: string | ||
| checkedBorderColor: string | ||
| checkboxCheckedColor: string | ||
| checkboxToggleCheckedColor: string |
Contributor
There was a problem hiding this comment.
I think that checkedToggleColor, checkedToggleBackground and checkedToggleBorderColor namings were fine.
to resolve undefined vars in base theme error
Safely set colors in checkboxVariables with lodash
…x/checkbox-themeing
…x/checkbox-themeing
…x/checkbox-themeing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Before:
After:
