Skip to content
This repository was archived by the owner on Mar 4, 2020. It is now read-only.

fix(Menu): theme bugs#1712

Merged
codepretty merged 22 commits intomasterfrom
fix/menu-style-bugs
Aug 12, 2019
Merged

fix(Menu): theme bugs#1712
codepretty merged 22 commits intomasterfrom
fix/menu-style-bugs

Conversation

@bcalvery
Copy link
Contributor

@bcalvery bcalvery commented Jul 23, 2019

Small tweaks to Menu border color and Menu Item height to align to Teams Redlines.

@codecov
Copy link

codecov bot commented Jul 23, 2019

Codecov Report

Merging #1712 into master will decrease coverage by 0.01%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1712      +/-   ##
==========================================
- Coverage   70.05%   70.03%   -0.02%     
==========================================
  Files         867      867              
  Lines        7431     7433       +2     
  Branches     2186     2187       +1     
==========================================
  Hits         5206     5206              
- Misses       2217     2219       +2     
  Partials        8        8
Impacted Files Coverage Δ
.../src/themes/teams/components/Menu/menuVariables.ts 33.33% <ø> (ø) ⬆️
packages/react/src/components/Menu/MenuItem.tsx 34.04% <0%> (ø) ⬆️
...src/themes/teams/components/Menu/menuItemStyles.ts 7.08% <0%> (-0.12%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ad90901...db4b8c3. Read the comment docs.

@vercel vercel bot temporarily deployed to staging July 26, 2019 21:23 Inactive
@bcalvery bcalvery removed the 🚧 WIP label Jul 26, 2019
Copy link
Member

@levithomason levithomason left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changelog needs and update, otherwise good to go 👍

@vercel vercel bot temporarily deployed to staging August 12, 2019 13:36 Inactive
@codepretty codepretty merged commit 4574256 into master Aug 12, 2019
@delete-merged-branch delete-merged-branch bot deleted the fix/menu-style-bugs branch August 12, 2019 23:59
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants