This repository was archived by the owner on Mar 4, 2020. It is now read-only.
fix(FocusTrapZone): firstFocusableSelector is fragile#1732
Merged
Conversation
added 2 commits
July 29, 2019 15:59
sophieH29
added
🚀 ready for review
🧰 fix
sophieH29
requested review from
dvdzkwsk,
kuzhelov,
layershifter,
levithomason,
miroslavstastny and
mnajdova
as code owners
Codecov Report
@@ Coverage Diff @@
## master #1732 +/- ##
=======================================
Coverage 70.98% 70.98%
=======================================
Files 860 860
Lines 7156 7156
Branches 2058 2078 +20
=======================================
Hits 5080 5080
Misses 2070 2070
Partials 6 6
Continue to review full report at Codecov.
|
silviuaavram
approved these changes
Jul 30, 2019
layershifter
approved these changes
Jul 30, 2019
Member
|
Please describe breaking changes in PR description 😼 |
delete-merged-branch
bot
deleted the
fix/ftz-first-focusable-selector-is-fragile
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1566
Breaking change
Before:
firstFocusableSelectorwas used only to specify the class name string selector..was appended to the passed value.After:
firstFocusableSelectorcan be any string selector as is used in API fordocument.querySelectorThis PR introduces changes to
FocusTrapZoneandAutoFocusZoneto not limit a user to using class selectors only.Now it's a user responsibility to pass the whole string selector whether it's a
.blahor#blahor tagblahetc. If this element won't be found in the container, the first tabbable element will be selected