chore(Tree): rename to HierarchicalTree#1752
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1752 +/- ##
=======================================
Coverage 69.97% 69.97%
=======================================
Files 868 868
Lines 7335 7335
Branches 2142 2119 -23
=======================================
Hits 5133 5133
Misses 2196 2196
Partials 6 6
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Where / how can we mark as depreciated?
There was a problem hiding this comment.
Created request #1756 to properly handle depreciated methods in DocSite. For now, can we update text descriptions to make this clear.
There was a problem hiding this comment.
should we do this in the current PR?
There was a problem hiding this comment.
In the current PR, just put (DEPRECATED) to the beginning of the description of the Tree. See https://stardust-ui.github.io/react/components/item-layout as an example.
There was a problem hiding this comment.
We should also provide console warnings when using deprecated components/props once we ship the new Tree.
jurokapsiar
left a comment
There was a problem hiding this comment.
please add a breaking change changelog entry
6ad3315 to
738422a
Compare
Renamed
TreetoHierarchicalTree,TreeItemtoHierarchicalTreeItemandTreeTitletoHierarchicalTreeTitle.Renamed
treeBehaviortohierarchicalTreeBehavior,treeItemBehaviortohierarchicalTreeItemBehavior,treeTitleBehaviortohierarchicalTreeTitleBehaviorandsubtreeBehaviortohierarchicalSubtreeBehavior.BREAKING CHANGE MITIGATION
Perform the renames where the components and behaviors are used.