Conversation
mnajdova
requested review from
dvdzkwsk,
kuzhelov,
levithomason and
miroslavstastny
as code owners
Codecov Report
@@ Coverage Diff @@
## master #177 +/- ##
=========================================
- Coverage 67.69% 67.09% -0.6%
=========================================
Files 103 101 -2
Lines 1461 1395 -66
Branches 299 279 -20
=========================================
- Hits 989 936 -53
+ Misses 468 456 -12
+ Partials 4 3 -1
Continue to review full report at Codecov.
|
|
Shorthand vs Children API examples render differently |
|
Thanks for the catch @miroslavstastny, it is fixed now. |
# Conflicts: # CHANGELOG.md
# Conflicts: # CHANGELOG.md # src/components/Button/Button.tsx # src/themes/teams/components/Button/buttonStyles.ts
miroslavstastny
left a comment
miroslavstastny
left a comment
There was a problem hiding this comment.
I am fine with the API proposal. I would like to see a use case for the text button in order to be able to discuss it's styling aspects - I am not sure if you want to keep the same button dimensions (height and padding).
docs/src/examples/components/Button/Variations/ButtonExampleText.shorthand.tsx
Outdated
Show resolved
Hide resolved
| /> | ||
| <ComponentExample | ||
| title="Text" | ||
| description="A button can be shown in form of a text to indicate some less-pronounced actions" |
There was a problem hiding this comment.
nit's nit: just for the sake of consistency, lets put dot at the end of description :)
There was a problem hiding this comment.
This is not a nit, is valid thing to be fixed as this is shown in our docs page :)
| return Icon.create(icon, { | ||
| defaultProps: { | ||
| xSpacing: !content ? 'none' : iconPosition === 'after' ? 'before' : 'after', | ||
| variables: { |
|
Thanks for the updates @kuzhelov, will update the branch and merge it. |
# Conflicts: # CHANGELOG.md # src/themes/teams/components/Button/buttonStyles.ts
-fixed console errors in the buttons examples
4 participants
Button
Adding text variant to the button, that will display the button without any background and border.
TODO
API Proposal
text: boolean
A button can be formatted to show only text in order to indicate some less-pronounced actions.
At this moment, the styles of the buttons containing the text prop, are just reducing the background and border, and on hover are altering the color of the text to be the
brandcolor. We may need to change this, as the current text color of the primary button is white, which is maybe not the most appropriate one. Once the API is approved, we can agree on colors used for the default, primary and secondary variations of the text button.