This repository was archived by the owner on Mar 4, 2020. It is now read-only.
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1823 +/- ##
==========================================
- Coverage 69.56% 69.52% -0.04%
==========================================
Files 875 875
Lines 7596 7607 +11
Branches 2219 2222 +3
==========================================
+ Hits 5284 5289 +5
- Misses 2304 2310 +6
Partials 8 8
Continue to review full report at Codecov.
|
Member
|
What about the cases where the dismiss is not an icon X, but it is in the actions? Seems most implementations use a separate concept for |
sophieH29
approved these changes
Aug 20, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

BREAKING CHANGES
actionslot was renamed todismissActiondismissAction, you need to usedismissiblepropBefore
After
Add
visiblepropIt provides a better experience when
Alertis used withdismissibleprop as because it allows to useAlertin autocontrolled mode.actionslot was renamed todismissActionThe most common thing that all
Alert-like components have it's a dismiss action that hides the component. It's the main action that I found with these components, so it's usage should be simplified.Bootstrap |
dismissibleSUIR/SUI |
onDismiss,DismissableFabric UI |
dismissButtonAntDesign |
closableLightning DS |
close buttonBackpack |
DismissableAtlasKit |
DismissAdd
actionsslotTo have multiple action buttons is also quite common and this is a different that have
dismissable.AtlasKit |
actionsFabric UI |
actions