This repository was archived by the owner on Mar 4, 2020. It is now read-only.
fix(Checkbox): Checkbox should be vertically aligned with content#1857
Merged
codepretty merged 12 commits intomasterfrom Aug 30, 2019
Merged
fix(Checkbox): Checkbox should be vertically aligned with content#1857codepretty merged 12 commits intomasterfrom
codepretty merged 12 commits intomasterfrom
Conversation
bcalvery
requested review from
dvdzkwsk,
kuzhelov,
layershifter,
levithomason,
miroslavstastny and
mnajdova
as code owners
Codecov Report
@@ Coverage Diff @@
## master #1857 +/- ##
=======================================
Coverage 69.74% 69.74%
=======================================
Files 885 885
Lines 7786 7786
Branches 2274 2248 -26
=======================================
Hits 5430 5430
Misses 2348 2348
Partials 8 8
Continue to review full report at Codecov.
|
bcalvery
changed the title
Contributor
|
Let's add one example to potentially catch regressions for this in future. |
codepretty
approved these changes
Aug 28, 2019
packages/react/src/themes/teams/components/Checkbox/checkboxStyles.ts
Outdated
Show resolved
Hide resolved
layershifter
suggested changes
Aug 30, 2019
Member
layershifter
left a comment
layershifter
left a comment
There was a problem hiding this comment.
Should be the same thing applied to toggle?
layershifter
added
the
needs author changes
bcalvery
removed
the
needs author changes
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Before:
After:
