This repository was archived by the owner on Mar 4, 2020. It is now read-only.
fix(factories): add types to createShorthandFactory() methods#1875
Merged
fix(factories): add types to createShorthandFactory() methods#1875
Conversation
lucivpav
requested review from
dvdzkwsk,
kuzhelov,
layershifter,
levithomason,
miroslavstastny and
mnajdova
as code owners
lucivpav
commented
Sep 2, 2019
layershifter
reviewed
Sep 2, 2019
layershifter
reviewed
Sep 2, 2019
layershifter
reviewed
Sep 2, 2019
packages/react/src/lib/factories.ts
Outdated
| } | ||
| export type CreateShorthandFactoryConfig = CreateShorthandFactoryConfigInner | ||
| export type CreateShorthandFactoryResult = ( | ||
| a: ShorthandValue<UIComponentProps>, |
Member
There was a problem hiding this comment.
Suggested change
| a: ShorthandValue<UIComponentProps>, | |
| value: ShorthandValue<UIComponentProps>, |
Member
There was a problem hiding this comment.
Suggested change
| a: ShorthandValue<UIComponentProps>, | |
| a: ShorthandValue<P>, |
Actually, let's make it generic and accept component props there. Hope that it will work
layershifter
reviewed
Sep 2, 2019
layershifter
reviewed
Sep 2, 2019
layershifter
reviewed
Sep 2, 2019
layershifter
reviewed
Sep 2, 2019
Codecov Report
@@ Coverage Diff @@
## master #1875 +/- ##
======================================
Coverage 69.7% 69.7%
======================================
Files 886 886
Lines 7797 7797
Branches 2258 2258
======================================
Hits 5435 5435
Misses 2352 2352
Partials 10 10
Continue to review full report at Codecov.
|
…o "value, options", avoid cirtular reference in factories.ts
layershifter
reviewed
Sep 3, 2019
|
|
||
| const indicatorWithDefaults = indicator === undefined ? {} : indicator | ||
| const defaultIndicator = { name: vertical ? 'stardust-arrow-end' : 'stardust-arrow-down' } | ||
| const indicatorWithDefaults = indicator === undefined ? defaultIndicator : indicator |
Member
There was a problem hiding this comment.
Are these changes required? Can we revert them?
Contributor
Author
There was a problem hiding this comment.
It is required, because Type {} is not assignable to type Props<IconProps>.
layershifter
reviewed
Sep 3, 2019
| const { contentRef, children, content, indicator, active } = this.props | ||
| const indicatorWithDefaults = indicator === undefined ? {} : indicator | ||
| const defaultIndicator = { name: active ? 'stardust-arrow-down' : 'stardust-arrow-end' } | ||
| const indicatorWithDefaults = indicator === undefined ? defaultIndicator : indicator |
Member
There was a problem hiding this comment.
layershifter
approved these changes
Sep 3, 2019
Contributor
Author
|
Another PR: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1865
The new type is
Won't compile
Will compile
And this will unfortunately also compile