This repository was archived by the owner on Mar 4, 2020. It is now read-only.
feat(prototypes): Allow attaching notification to a target ref in CopyToClipboard prototype#1900
Merged
jurokapsiar merged 15 commits intomasterfrom Oct 4, 2019
Merged
Conversation
jurokapsiar
requested review from
dvdzkwsk,
kuzhelov,
layershifter,
levithomason,
miroslavstastny and
mnajdova
as code owners
Codecov Report
@@ Coverage Diff @@
## master #1900 +/- ##
==========================================
+ Coverage 76.71% 76.71% +<.01%
==========================================
Files 160 160
Lines 5492 5493 +1
Branches 1603 1604 +1
==========================================
+ Hits 4213 4214 +1
Misses 1266 1266
Partials 13 13
Continue to review full report at Codecov.
|
lucivpav
changed the title
lucivpav
reviewed
Sep 9, 2019
layershifter
reviewed
Sep 9, 2019
layershifter
reviewed
Sep 9, 2019
layershifter
reviewed
Sep 9, 2019
layershifter
reviewed
Sep 9, 2019
layershifter
reviewed
Sep 9, 2019
layershifter
reviewed
Sep 9, 2019
layershifter
reviewed
Sep 9, 2019
layershifter
changed the title
pompomon
reviewed
Oct 2, 2019
added 3 commits
October 2, 2019 14:35
…st-ui/react into proto/notification-target
layershifter
reviewed
Oct 3, 2019
layershifter
reviewed
Oct 3, 2019
layershifter
reviewed
Oct 3, 2019
layershifter
approved these changes
Oct 3, 2019
added 2 commits
October 4, 2019 14:52
…st-ui/react into proto/notification-target
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Notification button can be inside of a submenu - after clicking on it, the submenu closes and developer might want to attach the notification to the parent menu item.