This repository was archived by the owner on Mar 4, 2020. It is now read-only.
feat(List): behavior, example and prototype for navigable list#1904
Merged
jurokapsiar merged 6 commits intomasterfrom Sep 12, 2019
Merged
feat(List): behavior, example and prototype for navigable list#1904jurokapsiar merged 6 commits intomasterfrom
jurokapsiar merged 6 commits intomasterfrom
Conversation
jurokapsiar
requested review from
dvdzkwsk,
kuzhelov,
layershifter,
levithomason,
miroslavstastny and
mnajdova
as code owners
jurokapsiar
added
accessibility
jurokapsiar
changed the title
Codecov Report
@@ Coverage Diff @@
## master #1904 +/- ##
==========================================
+ Coverage 69.87% 69.94% +0.07%
==========================================
Files 890 892 +2
Lines 7783 7788 +5
Branches 2275 2254 -21
==========================================
+ Hits 5438 5447 +9
+ Misses 2335 2331 -4
Partials 10 10
Continue to review full report at Codecov.
|
Codecov Report
@@ Coverage Diff @@
## master #1904 +/- ##
==========================================
- Coverage 70.43% 70.41% -0.03%
==========================================
Files 881 879 -2
Lines 7790 7743 -47
Branches 2275 2271 -4
==========================================
- Hits 5487 5452 -35
+ Misses 2293 2281 -12
Partials 10 10
Continue to review full report at Codecov.
|
jurokapsiar
commented
Sep 11, 2019
docs/src/examples/components/List/Types/ListExampleNavigbale.shorthand.tsx
Show resolved
Hide resolved
jurokapsiar
changed the title
miroslavstastny
approved these changes
Sep 12, 2019
layershifter
pushed a commit
that referenced
this pull request
Sep 13, 2019
* accessibility for horizontal list * better prop types, add steps test * changelog * fix steps test (cherry picked from commit 7ca52d9)
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
After discussions with screen reader vendors, the behavior should be:
Prototype shows how to attach context menu to the list items. This PR includes necessary fixes to make it work correctly.