This repository was archived by the owner on Mar 4, 2020. It is now read-only.
feat(Tree): add behaviors with list/listitem roles#1928
Merged
silviuaavram merged 16 commits intomasterfrom Sep 19, 2019
Merged
feat(Tree): add behaviors with list/listitem roles#1928silviuaavram merged 16 commits intomasterfrom
silviuaavram merged 16 commits intomasterfrom
Conversation
silviuaavram
requested review from
dvdzkwsk,
kuzhelov,
layershifter,
levithomason,
miroslavstastny and
mnajdova
as code owners
silviuaavram
added
accessibility
Codecov Report
@@ Coverage Diff @@
## master #1928 +/- ##
=========================================
+ Coverage 70.39% 70.4% +<.01%
=========================================
Files 889 892 +3
Lines 7851 7867 +16
Branches 2264 2271 +7
=========================================
+ Hits 5527 5539 +12
- Misses 2313 2315 +2
- Partials 11 13 +2
Continue to review full report at Codecov.
|
lucivpav
reviewed
Sep 16, 2019
| } | ||
|
|
||
| export type TreeItemBehaviorProps = { | ||
| /** Indicated if tree title has a subtree */ |
Contributor
There was a problem hiding this comment.
Suggested change
| /** Indicated if tree title has a subtree */ | |
| /** Indicates whether `TreeTitle` has a subtree */ |
| role: 'none', | ||
| ...(props.hasSubtree && { | ||
| 'aria-expanded': props.open, | ||
| 'aria-expanded': props.open ? 'true' : 'false', |
Contributor
There was a problem hiding this comment.
There are a few instances in Stardust where we pass a boolean to aria-expanded. Let's report it as an issue?
Collaborator
Author
There was a problem hiding this comment.
hmm let me take a look
Collaborator
Author
There was a problem hiding this comment.
for consistency I made this one boolean as well. what do you think?
| export default treeTitleAsListItemTitleBehavior | ||
|
|
||
| type TreeTitleBehavior = { | ||
| /** Indicated if tree title has a subtree */ |
Contributor
There was a problem hiding this comment.
Suggested change
| /** Indicated if tree title has a subtree */ | |
| /** Indicates whether `TreeTitle` has a subtree */ |
|
|
||
| describe('TreeItemAsListItemBehavior', () => { | ||
| describe('role', () => { | ||
| test(`is 'none' if not a leaf`, () => { |
Contributor
There was a problem hiding this comment.
How about adding a test where its a leaf?
| expect(expectedResult.attributes.root.role).toEqual('treeitem') | ||
| }) | ||
|
|
||
| test(`is 'treeitem' if not a leaf`, () => { |
Contributor
There was a problem hiding this comment.
Suggested change
| test(`is 'treeitem' if not a leaf`, () => { | |
| test(`is 'treeitem' if a leaf`, () => { |
| }) | ||
| } | ||
|
|
||
| type TreeBehaviorProps = {} & Pick<AccessibilityAttributes, 'aria-labelledby'> |
Member
There was a problem hiding this comment.
Suggested change
| type TreeBehaviorProps = {} & Pick<AccessibilityAttributes, 'aria-labelledby'> | |
| type TreeBehaviorProps = Pick<AccessibilityAttributes, 'aria-labelledby'> |
nit, currently looks a bit strange
layershifter
approved these changes
Sep 17, 2019
jurokapsiar
suggested changes
Sep 17, 2019
Contributor
jurokapsiar
left a comment
jurokapsiar
left a comment
There was a problem hiding this comment.
Looks good to me and I think it is as good as it currently can be.
Can you please add an example? It's quite complex to put all the behaviors on the right place
…rdust-ui/react into chore/tree-as-list-behaviors
jurokapsiar
approved these changes
Sep 19, 2019
Contributor
|
pls add changelog before merging |
lucivpav
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Needed in order to make VO navigation possible. It will read the tree as a list, but it will calculate the list item accordingly, based on the level, setsize, posinset.
Feedback on how to name these behaviors?
Also added missing tests for tree behaviors.