Skip to content
This repository was archived by the owner on Mar 4, 2020. It is now read-only.

fix(theme): updating bodyBackground color for Teams dark theme#1961

Merged
codepretty merged 3 commits intomasterfrom
fix-body-background
Sep 24, 2019
Merged

fix(theme): updating bodyBackground color for Teams dark theme#1961
codepretty merged 3 commits intomasterfrom
fix-body-background

Conversation

@codepretty
Copy link
Collaborator

@codepretty codepretty commented Sep 23, 2019

For reference, #1478 and #1870

**This will create a lot of screener regressions, so any help reviewing or thinking about unintended consequences would be helpful!

@codepretty codepretty changed the title fix: Update bodyBackground color for Teams dark theme fix(theme): updating bodyBackground color for Teams dark theme Sep 23, 2019
@codecov
Copy link

codecov bot commented Sep 23, 2019

Codecov Report

Merging #1961 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1961   +/-   ##
=======================================
  Coverage   70.27%   70.27%           
=======================================
  Files         893      893           
  Lines        7892     7892           
  Branches     2309     2285   -24     
=======================================
  Hits         5546     5546           
  Misses       2333     2333           
  Partials       13       13
Impacted Files Coverage Δ
...kages/react/src/themes/teams-dark/siteVariables.ts 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 15db9b8...e14dbc7. Read the comment docs.

@levithomason
Copy link
Member

levithomason commented Sep 24, 2019

@codepretty, I went through all 142 screener diffs ( 😅) and confirmed only the background color was affected.

This was almost always just the body color except for two items:

  1. In the case of some menu examples the ul element also changed its background color. I believe this is correct and intentional however as the Menu element takes on the body background color.
  2. Some SVG elements seem to be triggering a diff, but the glyphs look identical to my eye.

Example diff showing these two issues can be seen here.

I think it is safe to merge.

@codepretty codepretty merged commit 89b28d4 into master Sep 24, 2019
@codepretty codepretty deleted the fix-body-background branch September 24, 2019 19:10
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants