This repository was archived by the owner on Mar 4, 2020. It is now read-only.
fix(theme): updating bodyBackground color for Teams dark theme#1961
Merged
codepretty merged 3 commits intomasterfrom Sep 24, 2019
Merged
fix(theme): updating bodyBackground color for Teams dark theme#1961codepretty merged 3 commits intomasterfrom
bodyBackground color for Teams dark theme#1961codepretty merged 3 commits intomasterfrom
Conversation
bodyBackground color for Teams dark themebodyBackground color for Teams dark theme
Codecov Report
@@ Coverage Diff @@
## master #1961 +/- ##
=======================================
Coverage 70.27% 70.27%
=======================================
Files 893 893
Lines 7892 7892
Branches 2309 2285 -24
=======================================
Hits 5546 5546
Misses 2333 2333
Partials 13 13
Continue to review full report at Codecov.
|
jurokapsiar
approved these changes
Sep 24, 2019
Member
|
@codepretty, I went through all 142 screener diffs ( 😅) and confirmed only the background color was affected. This was almost always just the body color except for two items:
Example diff showing these two issues can be seen here. I think it is safe to merge. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For reference, #1478 and #1870
**This will create a lot of screener regressions, so any help reviewing or thinking about unintended consequences would be helpful!