This repository was archived by the owner on Mar 4, 2020. It is now read-only.
feat(Menu): Update styling for *primary underlined* to match Teams style#20
Merged
miroslavstastny merged 5 commits intomasterfrom Aug 6, 2018
Merged
Conversation
miroslavstastny
requested review from
dvdzkwsk,
kuzhelov,
levithomason and
mnajdova
as code owners
Codecov Report
@@ Coverage Diff @@
## master #20 +/- ##
==========================================
- Coverage 87.45% 87.37% -0.08%
==========================================
Files 74 74
Lines 1124 1125 +1
Branches 210 200 -10
==========================================
Hits 983 983
- Misses 137 138 +1
Partials 4 4
Continue to review full report at Codecov.
|
miroslavstastny
changed the title
Closed
11 tasks
notandrew
approved these changes
Jul 31, 2018
levithomason
approved these changes
Aug 3, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Menu underlined primary
Style of the underlined primary menu was updated to match Teams look and feel.
Stardust Before:
Stardust After:
Real Teams:
TODO
Update glossary props tableAPI Proposal
The main change is that previously the whole menu item was underlined but now only the caption is underlined.
I was thinking about implementing it conditionally using
fittedprop but I do not see any use for the old look in Teams. For that reason I consider it the only look for underlined menu in Teams theme.Clone of stardust-ui/react-old#107