This repository was archived by the owner on Mar 4, 2020. It is now read-only.
fix(Popper): patch popper to use the correct window instance#2028
Merged
jurokapsiar merged 8 commits intomasterfrom Oct 17, 2019
Merged
fix(Popper): patch popper to use the correct window instance#2028jurokapsiar merged 8 commits intomasterfrom
jurokapsiar merged 8 commits intomasterfrom
Conversation
jurokapsiar
requested review from
dvdzkwsk,
kuzhelov,
layershifter,
levithomason,
miroslavstastny and
mnajdova
as code owners
Codecov Report
@@ Coverage Diff @@
## master #2028 +/- ##
==========================================
+ Coverage 75.83% 75.84% +0.01%
==========================================
Files 160 160
Lines 5569 5573 +4
Branches 1611 1611
==========================================
+ Hits 4223 4227 +4
Misses 1332 1332
Partials 14 14
Continue to review full report at Codecov.
|
layershifter
approved these changes
Oct 17, 2019
added 4 commits
October 17, 2019 15:26
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Popper is using global window when calling requestAnimationFrame. Patch it to use the correct window.
An issue will be created in popper to fix this properly.