Conversation
codepretty
requested review from
dvdzkwsk,
kuzhelov,
levithomason,
miroslavstastny and
mnajdova
as code owners
Codecov Report
@@ Coverage Diff @@
## master #205 +/- ##
=======================================
Coverage 89.23% 89.23%
=======================================
Files 50 50
Lines 836 836
Branches 130 119 -11
=======================================
Hits 746 746
Misses 86 86
Partials 4 4
Continue to review full report at Codecov.
|
| const TextSizesExampleShorthand = () => ( | ||
| <div> | ||
| <Text size="xs">Dicta voluptatum dolorem.</Text> | ||
| <Text size="xs" content="Dicta voluptatum dolorem." /> |
|
|
||
| const TextSizesExample = () => ( | ||
| <div> | ||
| <Text size="xs">Dicta voluptatum dolorem.</Text> |
There was a problem hiding this comment.
actually, this raises another point related to the values used for sizes. The problem is that it is hard to intuitively reason for the client about, say, which one is bigger: xl or 2x. Would propose to use values that are more intuitive in this sense (and address the issue by means of separate PR).
Quite similar sentiments are expressed in #136.
There was a problem hiding this comment.
Completely agree. My next PR is going to use a theme-based enum to show the appropriate sizes.
What I'm still not sure about is what to do for naming and how that could vary among themes...
kuzhelov
left a comment
kuzhelov
left a comment
There was a problem hiding this comment.
changelog.md should be updated as this PR introduces publicly visible changes
4 participants
Updating the text doc to have all examples & have accessibility info
Before
After
