Skip to content
This repository was archived by the owner on Mar 4, 2020. It is now read-only.

feat(menu): Vertical menu#21

Merged
miroslavstastny merged 4 commits intomasterfrom
feat/menu-vertical
Aug 1, 2018
Merged

feat(menu): Vertical menu#21
miroslavstastny merged 4 commits intomasterfrom
feat/menu-vertical

Conversation

@miroslavstastny
Copy link
Member

@miroslavstastny miroslavstastny commented Jul 30, 2018

Menu

A vertical menu displays elements vertically.
This is the basic implementation which covers default menu only. Other variations will be handled in separate PR(s).

TODO

  • Conformance test
  • Minimal doc site example
  • Stardust base theme
  • Teams Light theme
  • Teams Dark theme
  • Teams Contrast theme
  • Confirm RTL usage
  • W3 accessibility check
  • Stardust accessibility check
  • Update glossary props table
  • Update the CHANGELOG.md

API Proposal

Vertical

image

A vertical menu displays elements vertically.

<Menu vertical>
  <Menu.Item vertical name='inbox' active={activeItem === 'inbox'} onClick={this.handleItemClick}>
    Inbox
  </Menu.Item>

  <Menu.Item vertical name='spam' active={activeItem === 'spam'} onClick={this.handleItemClick}>
    Spam
  </Menu.Item>

  <Menu.Item vertical name='updates' active={activeItem === 'updates'} onClick={this.handleItemClick}>
    Updates
  </Menu.Item>
</Menu>
<button>Click</button>

@codecov
Copy link

codecov bot commented Jul 30, 2018

Codecov Report

Merging #21 into master will increase coverage by 0.12%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #21      +/-   ##
==========================================
+ Coverage   82.73%   82.86%   +0.12%     
==========================================
  Files          59       59              
  Lines         840      846       +6     
  Branches      180      193      +13     
==========================================
+ Hits          695      701       +6     
  Misses        141      141              
  Partials        4        4
Impacted Files Coverage Δ
src/components/Menu/menuRules.ts 100% <100%> (ø) ⬆️
src/components/Menu/MenuItem.tsx 100% <100%> (ø) ⬆️
src/components/Menu/menuItemRules.ts 88.88% <100%> (+2.52%) ⬆️
src/components/Menu/Menu.tsx 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c7b7621...c84df4e. Read the comment docs.

@miroslavstastny miroslavstastny changed the title [WIP] feat(menu): Vertical menu feat(menu): Vertical menu Jul 30, 2018
@miroslavstastny miroslavstastny force-pushed the feat/menu-vertical branch 2 times, most recently from bbf9c3f to f701717 Compare July 30, 2018 16:19
@mnajdova
Copy link
Contributor

The primary implementation of the vertical menu is not consistent with the default:

image

Is this going to be implemented in separate PR? I would rather have this implemented in this PR, as the only thing not corresponding is the background color of the active and hovered ListItems.

@mnajdova
Copy link
Contributor

I didn't have the latest changes localy. Looks ok, approved.

@miroslavstastny miroslavstastny merged commit 31bd156 into master Aug 1, 2018
@miroslavstastny miroslavstastny deleted the feat/menu-vertical branch August 1, 2018 07:50
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants