This repository was archived by the owner on Mar 4, 2020. It is now read-only.
perf: enable tree shaking for Webpack#224
Merged
levithomason merged 1 commit intomasterfrom Sep 13, 2018
Merged
Conversation
96e1c4d to
729a413
Compare
Contributor
dvdzkwsk
approved these changes
Sep 13, 2018
Collaborator
|
@levithomason how much did you benefit in package size from this change? I see you are using Webpack 3. I didn't realize |
Member
Author
|
The docs will always import 100% of the features so the size will be maxed at all times. The change here was made for consumers to benefit from. We are currently working on library level perf tracking #141 and library level bundle size tracking #97. It would be nice to track partial use bundle size as well. |
Member
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

This PR sets
sideEffects: falsein ourpackage.jsonto inform Webpack that our library is safe for tree shaking.https://webpack.js.org/guides/tree-shaking