This repository was archived by the owner on Mar 4, 2020. It is now read-only.
fix(Provider): not rendering fonts#227
Merged
levithomason merged 1 commit intomasterfrom Sep 14, 2018
Merged
Conversation
levithomason
requested review from
dvdzkwsk,
kuzhelov,
miroslavstastny and
mnajdova
as code owners
levithomason
force-pushed
the
fix/public
branch
from
ceaae68 to
4cc2a74
Compare
levithomason
commented
Sep 14, 2018
package.json
Outdated
Member
Author
There was a problem hiding this comment.
We need to copy docs/src/public to docs/dist on build. Otherwise, the font files are not included.
levithomason
commented
Sep 14, 2018
src/components/Provider/Provider.tsx
Outdated
Member
Author
There was a problem hiding this comment.
Fonts were also not being rendered because path was being used here instead of paths. Added typings to ensure it doesn't happen again.
levithomason
commented
Sep 14, 2018
Member
Author
There was a problem hiding this comment.
Unrelated freebie. The initial component example from a generated component had no content. Added some here so something shows up in the docs.
levithomason
changed the title
levithomason
force-pushed
the
fix/public
branch
from
4cc2a74 to
b535868
Compare
Member
Author
|
This is blocking other work... merging |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently, font faces are not being applied correctly in the docs. This turned out to be due to both our doc build and a Provider bug.