Skip to content
This repository was archived by the owner on Mar 4, 2020. It is now read-only.

docs(chat-pane): chat-pane prototype#235

Merged
bmdalex merged 37 commits intomasterfrom
docs/chat-pane-prototype
Oct 3, 2018
Merged

docs(chat-pane): chat-pane prototype#235
bmdalex merged 37 commits intomasterfrom
docs/chat-pane-prototype

Conversation

@bmdalex
Copy link
Collaborator

@bmdalex bmdalex commented Sep 14, 2018 •
edited
Loading

Chat pane prototype

This PR contains a Chat pane prototype that comes under the new Prototypes section in the docs experience. This is not available in prod so users need to actually build the project to see the prototypes.

@bmdalex bmdalex force-pushed the docs/chat-pane-prototype branch 9 times, most recently from 71ba1bf to 029ffac Compare September 14, 2018 19:23
@bmdalex bmdalex force-pushed the docs/chat-pane-prototype branch from 029ffac to 6b683a9 Compare September 14, 2018 19:27
alinais
alinais reviewed Sep 17, 2018
View reviewed changes
@alinais
Copy link
Contributor

alinais commented Sep 17, 2018

I guess we have to polish a bit the UI, so that the buttons in the header would look more like in the real life, not quite like this:

image

@bmdalex
Copy link
Collaborator Author

bmdalex commented Sep 17, 2018

@alinais well this is a limitation we currently have in stardust; there's not much I can do to make them look better without improving current set of components we use here (especially icons). Here I see issues with:

  • poor SVG support to achieve proper styling (filling, border, hover, etc)
  • wrong icons (font awesome does not have the MS Teams icons)
  • font weight, not sure how to set properly or if we support that (button Icons on right side are too thick)
    Anything else here?

But I think most of these are taken care of in different PRs and will be reflected in the prototype later.

FYI @levithomason @kuzhelov

sophieH29
sophieH29 reviewed Sep 17, 2018
View reviewed changes
@codecov
Copy link

codecov bot commented Sep 20, 2018 •
edited
Loading

Codecov Report

Merging #235 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #235   +/-   ##
=======================================
  Coverage   89.63%   89.63%           
=======================================
  Files          62       62           
  Lines        1167     1167           
  Branches      150      150           
=======================================
  Hits         1046     1046           
  Misses        119      119           
  Partials        2        2
Impacted Files Coverage Δ
src/components/Segment/Segment.tsx 100% <ø> (ø) ⬆️
src/components/Chat/index.ts 100% <100%> (ø) ⬆️
src/components/Divider/index.ts 100% <100%> (ø) ⬆️
src/components/Status/index.ts 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b581ce2...35cdb3f. Read the comment docs.

@bmdalex
Copy link
Collaborator Author

bmdalex commented Sep 25, 2018

@mnajdova @kuzhelov can u pls offer final review? thx

@mnajdova mnajdova mentioned this pull request Oct 2, 2018
Closed
bmdalex added 2 commits October 3, 2018 04:48
@bmdalex
updates:
af641d4 
- sorted messages by date
- added all types of dividers between messages in correct places
- added correct timestamp and title attributes for timestamps
@bmdalex
Merge branch 'master' of https://github.com/stardust-ui/react into do…
3c33a3b 
…cs/chat-pane-prototype
mnajdova
mnajdova reviewed Oct 3, 2018
View reviewed changes
mnajdova
mnajdova reviewed Oct 3, 2018
View reviewed changes
mnajdova
mnajdova reviewed Oct 3, 2018
View reviewed changes
mnajdova
mnajdova reviewed Oct 3, 2018
View reviewed changes
mnajdova
mnajdova reviewed Oct 3, 2018
View reviewed changes
mnajdova
mnajdova approved these changes Oct 3, 2018
View reviewed changes
Copy link
Contributor

@mnajdova mnajdova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left couple of comments, otherwise nice work! :) Good to be merged after resolving those.

mnajdova
mnajdova reviewed Oct 3, 2018
View reviewed changes
mnajdova
mnajdova reviewed Oct 3, 2018
View reviewed changes
mnajdova
mnajdova reviewed Oct 3, 2018
View reviewed changes
@bmdalex bmdalex merged commit 6c53400 into master Oct 3, 2018
@bmdalex bmdalex deleted the docs/chat-pane-prototype branch October 3, 2018 13:46
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@dvdzkwsk dvdzkwsk Awaiting requested review from dvdzkwsk

@kuzhelov kuzhelov Awaiting requested review from kuzhelov

@levithomason levithomason Awaiting requested review from levithomason levithomason is a code owner

@miroslavstastny miroslavstastny Awaiting requested review from miroslavstastny miroslavstastny is a code owner

3 more reviewers

@alinais alinais alinais left review comments

@mnajdova mnajdova mnajdova approved these changes

@sophieH29 sophieH29 sophieH29 left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

🚀 ready for review

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@bmdalex @alinais @mnajdova @sophieH29