fix(Divider): Matching divider Teams theme to redlines#249
fix(Divider): Matching divider Teams theme to redlines#249codepretty merged 6 commits intomasterfrom
Conversation
Codecov Report
@@ Coverage Diff @@
## master #249 +/- ##
=======================================
Coverage 91.84% 91.84%
=======================================
Files 61 61
Lines 1042 1042
Branches 134 154 +20
=======================================
Hits 957 957
Misses 82 82
Partials 3 3Continue to review full report at Codecov.
|
1 similar comment
Codecov Report
@@ Coverage Diff @@
## master #249 +/- ##
=======================================
Coverage 91.84% 91.84%
=======================================
Files 61 61
Lines 1042 1042
Branches 134 154 +20
=======================================
Hits 957 957
Misses 82 82
Partials 3 3Continue to review full report at Codecov.
|
Codecov Report
@@ Coverage Diff @@
## master #249 +/- ##
=======================================
Coverage 92.57% 92.57%
=======================================
Files 62 62
Lines 1131 1131
Branches 147 147
=======================================
Hits 1047 1047
Misses 81 81
Partials 3 3Continue to review full report at Codecov.
|
|
Little bit worried about not applying any height on the Divider, as currently we used it also as an invisible divider between elements. Please take a look into this visual regression: https://screener.io/v2/states/rkGqtccHX.stardust-ui-react/fix%2Fdivider-redlines/1024x768/Chrome/portalexampleshorthandtsx-0 |
|
Maybe we add an optional buffer size between elements, but I'm not sure that we want a height set. That may make it harder to modify in the case where we want smaller spacers between objects. |

Matched divider styles for the Teams theme to the redlines. This includes updating colors, variable names, spacing.
In Teams theme, there are only 2 types of dividers
1. Default divider w/text

2. Primary, important divider w/text
