This repository was archived by the owner on Mar 4, 2020. It is now read-only.
Conversation
Codecov Report
@@ Coverage Diff @@
## master #286 +/- ##
==========================================
- Coverage 89.9% 89.62% -0.29%
==========================================
Files 62 62
Lines 1159 1166 +7
Branches 150 173 +23
==========================================
+ Hits 1042 1045 +3
- Misses 115 119 +4
Partials 2 2
Continue to review full report at Codecov.
|
63d86af to
7dd3d84
Compare
Collaborator
Author
|
ready for review: |
7dd3d84 to
c2e3104
Compare
Member
miroslavstastny
left a comment
There was a problem hiding this comment.
Code looks good, not sure about removing focus ring for all Menu types.
c2e3104 to
f3bc6f7
Compare
mnajdova
reviewed
Oct 2, 2018
mnajdova
approved these changes
Oct 2, 2018
Contributor
mnajdova
left a comment
There was a problem hiding this comment.
Left one comment for consideration, other then that, looks good by me. Please create an issue for the isFromKeyboard service explaining the problem you encountered.
alinais
approved these changes
Oct 2, 2018
f3bc6f7 to
e543111
Compare
miroslavstastny
approved these changes
Oct 2, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Menu
This PR main purposes:
TODO
Description
type="primary"All primary (

type="primary") menus get updated background foractive,focusandhoverstates.underlinedUnderlined menus get new styles for
active,focusandhoverstates.iconOnlyMenus with only icons as item get new styles for
active,focusandhoverstates.1. regular:
2. inverted (by tweeking variables):
3. vertical (with
verticalprop):