fix(Accordion): generate key for the Accordion.Content

[mnajdova]

Fix

This PR fixes #291

TODO

• Conformance test
• Update the CHANGELOG.md

There was a bug in the creation of the Content which prevented generation of keys, and a small bug where the complex content for the Accordion.Content was created. Those two are fixed now.

Important note

We support generation of keys, for the component that as content has some primitive value (string, number etc). If the content is something more complex (as in the last example of the docs), that the user is responsible for creating the key.

[codecov]

Codecov Report

Merging #305 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #305   +/-   ##
=======================================
  Coverage   89.63%   89.63%           
=======================================
  Files          62       62           
  Lines        1167     1167           
  Branches      150      150           
=======================================
  Hits         1046     1046           
  Misses        119      119           
  Partials        2        2

Impacted Files	Coverage Δ
src/components/Accordion/Accordion.tsx	65.3% <ø> (ø)	⬆️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 712c72e...cdc81b8. Read the comment docs.

[layershifter]

@mnajdova may be the better idea will be to pick the AccordionPanel component for SUIR? PR #3032 contains the updated component that uses Fragment API (AccordionPanel.js).

This allow handle keys on panels:

const panels = [
 {
    key: 'what-is-dog',
    title: 'What is a dog?',
    content: 'A dog is a type of domesticated animal.',
  },
  {
    key: 'kinds-of-dogs',
    title: 'What kinds of dogs are there?',
    content: 'There are many breeds of dogs.',
  },
]

[mnajdova]

@layershifter thanks for the reference on the AccordionPanel. I would not make that big changes at this moment, as the only issue we hit so far was the generation of the content's key which if fix with this PR. We can however consider refactoring this in the future, but I see having more things that should be considered, as supporting the as property, which would adding additional wrapper that the user doesn't really need. Will keep in mind this, if this component shows some other issues in the future.

[alinais]

@mnajdova @layershifter please create an RFC for further discussion around Accordion panels.

[alinais]

Accordion.Content ;)

[alinais]

meaning, that you can add the `

[mnajdova]

Thanks, pushed :)