This repository was archived by the owner on Mar 4, 2020. It is now read-only.
[RFC] feat(slot): create generic slot component#335
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## master #335 +/- ##
==========================================
+ Coverage 89.59% 89.73% +0.14%
==========================================
Files 62 64 +2
Lines 1220 1237 +17
Branches 179 157 -22
==========================================
+ Hits 1093 1110 +17
Misses 125 125
Partials 2 2
Continue to review full report at Codecov.
|
levithomason
reviewed
Oct 8, 2018
levithomason
approved these changes
Oct 8, 2018
f68bd63 to
14d123e
Compare
mnajdova
reviewed
Oct 9, 2018
Contributor
There was a problem hiding this comment.
Maybe we can add here some description of the component and why it was introduced. This is not blocking this PR from being merged however.
mnajdova
approved these changes
Oct 9, 2018
14d123e to
6da13dc
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Slot
This PR contains:
Slotcomponent;contentprop to shorthand slotsTODO
API Proposal
contentprop as shorthandWe are now able to use
contentprop as real shorthand for our components if it's needed. Here are a couple of scenarios where this is useful:1. Usage of
wrappershorthand forInputcomponent in #3262. Usage of
contentprop forButtoncomponent that was transformed to shorthand in this PR: