This repository was archived by the owner on Mar 4, 2020. It is now read-only.
fix(Icon): Color & docs update for Teams theme#384
Merged
codepretty merged 8 commits intomasterfrom Oct 24, 2018
Merged
Conversation
codepretty
requested review from
dvdzkwsk,
kuzhelov,
levithomason,
miroslavstastny and
mnajdova
as code owners
Codecov Report
@@ Coverage Diff @@
## master #384 +/- ##
=======================================
Coverage 91.72% 91.72%
=======================================
Files 41 41
Lines 1341 1341
Branches 172 172
=======================================
Hits 1230 1230
Misses 107 107
Partials 4 4Continue to review full report at Codecov.
|
codepretty
changed the title
codepretty
changed the title
codepretty
added
redlines
28 tasks
kuzhelov
reviewed
Oct 23, 2018
kuzhelov
approved these changes
Oct 23, 2018
kuzhelov
reviewed
Oct 23, 2018
docs/src/examples/components/Icon/Usage/IconButtonExample.shorthand.tsx
Outdated
Show resolved
Hide resolved
kuzhelov
reviewed
Oct 23, 2018
Contributor
kuzhelov
left a comment
kuzhelov
left a comment
There was a problem hiding this comment.
please, see comments. Thanks!
kuzhelov
added
needs author feedback
codepretty
added
🚀 ready for review
and removed
needs author feedback
kuzhelov
reviewed
Oct 23, 2018
Contributor
kuzhelov
left a comment
kuzhelov
left a comment
There was a problem hiding this comment.
lets, please, agree on the example provided before merging these changes - other than that am totally for merging it 👍
kuzhelov
added
needs author feedback
…add this as a Usage example in the Button component in a future PR
kuzhelov
approved these changes
Oct 24, 2018
Contributor
kuzhelov
left a comment
kuzhelov
left a comment
There was a problem hiding this comment.
please, update the CHANGELOG before merge - thanks!
added 3 commits
October 24, 2018 11:19
… dealing with spacing/padding
…t-ui/react into feat/icon-color-redlines
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updating the color for icon Teams theme.. An icon will inherit the current color of the font unless a new color is explicitly passed to icon.
Added new Color section to the doc site under Variations
