This repository was archived by the owner on Mar 4, 2020. It is now read-only.
feat(segment): add inverted prop and improved styles#389
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## master #389 +/- ##
==========================================
+ Coverage 88.96% 88.96% +<.01%
==========================================
Files 41 41
Lines 1386 1387 +1
Branches 177 177
==========================================
+ Hits 1233 1234 +1
Misses 149 149
Partials 4 4
Continue to review full report at Codecov.
|
3257c73 to
2bb4970
Compare
4478bc8 to
53e4168
Compare
kuzhelov
reviewed
Oct 23, 2018
docs/src/examples/components/Segment/Variations/SegmentExampleInverted.tsx
Outdated
Show resolved
Hide resolved
kuzhelov
reviewed
Oct 23, 2018
docs/src/examples/components/Segment/Variations/SegmentExampleInverted.shorthand.tsx
Outdated
Show resolved
Hide resolved
kuzhelov
approved these changes
Oct 23, 2018
Contributor
kuzhelov
left a comment
There was a problem hiding this comment.
please, consider to use fallback options for siteVars.brand for those cases where those are not provided. I would even suggest to use some hardcoded colors for now, to make it easier for the client of these examples to get the idea
kuzhelov
reviewed
Oct 23, 2018
docs/src/examples/components/Segment/Variations/SegmentExampleInverted.shorthand.tsx
Outdated
Show resolved
Hide resolved
53e4168 to
b4f35d1
Compare
levithomason
suggested changes
Oct 24, 2018
docs/src/examples/components/Segment/Variations/SegmentExampleInverted.shorthand.tsx
Outdated
Show resolved
Hide resolved
6a30873 to
54ceaef
Compare
54ceaef to
e4151f3
Compare
mnajdova
reviewed
Nov 1, 2018
e4151f3 to
dcf4fc3
Compare
Collaborator
Author
|
@mnajdova @kuzhelov @levithomason |
mnajdova
approved these changes
Nov 2, 2018
c835ce7 to
b1be3b8
Compare
levithomason
approved these changes
Nov 7, 2018
Member
levithomason
left a comment
There was a problem hiding this comment.
Please merge after addressing comments!
docs/src/examples/components/Segment/Variations/SegmentExampleInverted.tsx
Outdated
Show resolved
Hide resolved
b1be3b8 to
980974c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Segment
This PR introduces following changes for
Segmentcomponent:invertedprop;colorvariable;contentslot andrenderContentmethod;TODO
API Proposal
Default
renders:
colorvariableA segment can different colors. Use
colorvariable to see the effect.renders

invertedwithcolorvariableA segment can have its colors inverted for contrast. Use
colorvariable to see the effect.renders
