This repository was archived by the owner on Mar 4, 2020. It is now read-only.
fix(Attachment): do not render progress value#402
Merged
miroslavstastny merged 2 commits intomasterfrom Oct 25, 2018
Merged
Conversation
levithomason
requested review from
dvdzkwsk,
kuzhelov,
miroslavstastny and
mnajdova
as code owners
Codecov Report
@@ Coverage Diff @@
## master #402 +/- ##
=======================================
Coverage 91.72% 91.72%
=======================================
Files 41 41
Lines 1341 1341
Branches 197 197
=======================================
Hits 1230 1230
Misses 107 107
Partials 4 4
Continue to review full report at Codecov.
|
miroslavstastny
approved these changes
Oct 25, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #385
This PR prevents the Attachment's
progressvalue from the rendered to the DOM. It is only used for styling purposes.Before
After