This repository was archived by the owner on Mar 4, 2020. It is now read-only.
fix: remove allowSyntheticDefaultImports and allow it on docs#46
Merged
levithomason merged 7 commits intomicrosoft:masterfrom Aug 3, 2018
Merged
fix: remove allowSyntheticDefaultImports and allow it on docs#46levithomason merged 7 commits intomicrosoft:masterfrom
levithomason merged 7 commits intomicrosoft:masterfrom
Conversation
aniknafs
requested review from
dvdzkwsk,
kuzhelov,
levithomason and
mnajdova
as code owners
dvdzkwsk
reviewed
Aug 3, 2018
src/components/Input/Input.tsx
Outdated
| const [htmlInputProps, restProps] = this.partitionProps() | ||
|
|
||
| const inputClasses = cx(classes.input) | ||
| const inputClasses = (cx as any)(classes.input) |
Contributor
There was a problem hiding this comment.
Can we yarn add --dev @types/classnames to avoid this?
Member
Author
There was a problem hiding this comment.
we do have it but it still throws
dvdzkwsk
approved these changes
Aug 3, 2018
Contributor
dvdzkwsk
left a comment
dvdzkwsk
left a comment
There was a problem hiding this comment.
Looks good. I think we can get rid of the as any for classnames by adding community typings.
Member
|
Just for posterity's sake, the reason for the change is to support all consumers (not just Teams 😃). |
levithomason
suggested changes
Aug 3, 2018
Member
levithomason
left a comment
levithomason
left a comment
There was a problem hiding this comment.
Please update the CHANGELOG.md in the root of the project.
Member
Author
|
changelog updated |
levithomason
approved these changes
Aug 3, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
allowSyntheticDefaultImports is not allowed on neither of teams-modular-packages/WebClient. This PR will disable it for /src but will allow it on the docs site.
As a result, all import statements from packages with no default import is updated:
e.g.
import React from 'react'-->import * as React from 'react'There are a few instances where a 3rd party dependency has an incomplete type def, which are skipped by type assertion:
e.g.
const inputClasses = cx(classes.input)-->const inputClasses = (cx as any)(classes.input)