This repository was archived by the owner on Mar 4, 2020. It is now read-only.
fix(dependencies): remove unused, move some to dev#51
Merged
levithomason merged 2 commits intomasterfrom Aug 7, 2018
Merged
Conversation
levithomason
requested review from
dvdzkwsk,
kuzhelov and
mnajdova
as code owners
levithomason
commented
Aug 7, 2018
| "fela-plugin-placeholder-prefixer": "^5.0.18", | ||
| "fela-plugin-prefixer": "^5.0.18", | ||
| "fela-plugin-rtl": "^1.0.6", | ||
| "hoist-non-react-statics": "^2.5.0", |
Codecov Report
@@ Coverage Diff @@
## master #51 +/- ##
=======================================
Coverage 87.37% 87.37%
=======================================
Files 74 74
Lines 1125 1125
Branches 200 200
=======================================
Hits 983 983
Misses 138 138
Partials 4 4Continue to review full report at Codecov.
|
levithomason
commented
Aug 7, 2018
| }, | ||
| "dependencies": { | ||
| "classnames": "^2.2.5", | ||
| "fbjs": "^0.8.16", |
Member
Author
There was a problem hiding this comment.
Only used in docs. dependencies should only include deps used in src. All others are only needed for our builds and are therefore devDependencies.
levithomason
commented
Aug 7, 2018
| "hoist-non-react-statics": "^2.5.0", | ||
| "keyboard-key": "^1.0.1", | ||
| "lodash": "^4.17.10", | ||
| "normalize.css": "^8.0.0", |
Member
Author
There was a problem hiding this comment.
Only used to create teams theme, which includes a stringified version of this module.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We currently have an unused dependency in our package.json and a couple dependencies that are actually devDependencies.