This repository was archived by the owner on Mar 4, 2020. It is now read-only.
docs(Accessibility): Display available behaviors for component#510
Merged
jurokapsiar merged 9 commits intomasterfrom Dec 7, 2018
Merged
docs(Accessibility): Display available behaviors for component#510jurokapsiar merged 9 commits intomasterfrom
jurokapsiar merged 9 commits intomasterfrom
Conversation
jurokapsiar
requested review from
dvdzkwsk,
kuzhelov,
levithomason,
miroslavstastny and
mnajdova
as code owners
layershifter
suggested changes
Nov 22, 2018
Member
layershifter
left a comment
layershifter
left a comment
There was a problem hiding this comment.
My opinion: this is a cool feature, but we should keep these things in docgen task because our docs components will become overcomplicated. We have doctrine, I almost sure that it can do the same more clearly.
This also can cause performance degrades.
layershifter
added
needs author feedback
jurokapsiar
added
🚀 ready for review
and removed
needs author feedback
Codecov Report
@@ Coverage Diff @@
## master #510 +/- ##
=========================================
Coverage ? 88.17%
=========================================
Files ? 42
Lines ? 1455
Branches ? 212
=========================================
Hits ? 1283
Misses ? 167
Partials ? 5
Continue to review full report at Codecov.
|
layershifter
approved these changes
Nov 22, 2018
sophieH29
approved these changes
Nov 23, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Display available behaviors for component.
Available behaviors can be specified using
@availabletag in theaccessibilityprop comment:The source of truth in this case is by purpose the component, as the plan forward is to separate behaviors to a separate repo. Then, behaviors will not have any knowledge about the components - components will only use the behaviors.
Once the issue with getting the default value using docgen directly will be resolved, we can also change this to use a compiler-checked reference.