This repository was archived by the owner on Mar 4, 2020. It is now read-only.
feat(Accessibility): Improvements to Menu accessibility behaviors#523
Merged
feat(Accessibility): Improvements to Menu accessibility behaviors#523
Conversation
sophieH29
requested review from
dvdzkwsk,
kuzhelov,
levithomason,
miroslavstastny and
mnajdova
as code owners
jurokapsiar
approved these changes
Nov 23, 2018
Codecov Report
@@ Coverage Diff @@
## master #523 +/- ##
=======================================
Coverage 88.32% 88.32%
=======================================
Files 42 42
Lines 1456 1456
Branches 212 187 -25
=======================================
Hits 1286 1286
Misses 165 165
Partials 5 5Continue to review full report at Codecov.
|
mnajdova
approved these changes
Nov 26, 2018
sophieH29
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
After spending some time on prototyping different use cases of using Menu, come up with the essential improvements addressed in this PR.
TODO: